[webkit-reviews] review denied: [Bug 54313] DocumentThreadableLoader doesn't support WebURLLoader usage. : [Attachment 82479] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 54313: DocumentThreadableLoader doesn't support WebURLLoader usage.
https://bugs.webkit.org/show_bug.cgi?id=54313

Attachment 82479: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=82479&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82479&action=review

r- to remove unnecessary overload. (If it is needed, give some short
explanation and I'll r+.)

> Source/WebCore/loader/DocumentThreadableLoader.cpp:240
> +void DocumentThreadableLoader::didReceiveCachedMetadata(SubresourceLoader*
loader, const char* data, int lengthReceived)

Ditto (with my comment below).

> Source/WebCore/loader/DocumentThreadableLoader.h:80
> +	   virtual void didReceiveCachedMetadata(SubresourceLoader*, const
char*, int lengthReceived);

Do you need this overload? (I though it was only here because
SubresourceLoaderClient was private but that is no longer true.)