[webkit-reviews] review granted: [Bug 54426] WebFrameLoaderClient::shouldGoToHistoryItem needs implementation : [Attachment 82483] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 15 10:36:34 PST 2011
Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 54426: WebFrameLoaderClient::shouldGoToHistoryItem needs implementation
https://bugs.webkit.org/show_bug.cgi?id=54426
Attachment 82483: Patch v2
https://bugs.webkit.org/attachment.cgi?id=82483&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82483&action=review
> Source/WebKit2/UIProcess/WebPageProxy.cpp:485
> + shouldGoToBackForwardItem = item ?
m_loaderClient.shouldGoToBackForwardListItem(this, item) : false;
I think this would look better with && rather than ? : for the null handling.
More information about the webkit-reviews
mailing list