[webkit-reviews] review requested: [Bug 54455] Web Inspector: move Database and DOMStorage related things from InspectorAgent : [Attachment 82482] [patch] second version

[bugzilla-daemon at webkit.org]

Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 54455: Web Inspector: move Database and DOMStorage related things from
InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54455

Attachment 82482: [patch] second version
https://bugs.webkit.org/attachment.cgi?id=82482&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
(In reply to comment #2)
> (From update of attachment 82447 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=82447&action=review
> 
> > Source/WebCore/ChangeLog:5
> > +	     Web Inspector: move Database and DOMStorage related things from
InspectorAgent to thecorresponding agents.
> 
> thecorresponding ->  the corresponding

done

> > Source/WebCore/inspector/InspectorAgent.cpp:142
> > +	 ,
m_databaseAgentResources(InspectorDatabaseAgent::createOfflineStorage())
> 
> Consider renaming createOfflineStorage to createStorage

done


> > Source/WebCore/inspector/InspectorAgent.cpp:463
> > +	 m_databaseAgentResources->pushDataCollectedOffline(m_frontend);
> 
> pushDataCollectedOffline should be a method on the database agent.

This call is moved into ctor of InspectorDatabaseAgent.

> > Source/WebCore/inspector/InspectorAgent.cpp:466
> > +	 m_domStorageAgentResources->pushDataCollectedOffline(m_frontend);
> 
> Same here.


This call is moved into ctor of InspectorDOMStorageAgent.