[webkit-reviews] review granted: [Bug 54426] WebFrameLoaderClient::shouldGoToHistoryItem needs implementation : [Attachment 82478] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 54426: WebFrameLoaderClient::shouldGoToHistoryItem needs implementation
https://bugs.webkit.org/show_bug.cgi?id=54426

Attachment 82478: Patch v1
https://bugs.webkit.org/attachment.cgi?id=82478&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82478&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:858
> +	   // We should never be considering navigating to an item that is not
actually in the back/forward list.
> +	   ASSERT_NOT_REACHED();

This can’t happen due to a race condition?

> Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:123
> +    return historyItemToIDMap().get(item);

If this can be passed 0 then it needs a special case for 0 to return 0 since
get would crash. If not, then I suggest an extra assert even though HashMap
will fail an assertion too.