[webkit-reviews] review granted: [Bug 54425] Extract a function to process ancestor and their sibling nodes from processContents : [Attachment 82400] 54425
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 15 09:15:07 PST 2011
Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 54425: Extract a function to process ancestor and their sibling nodes from
processContents
https://bugs.webkit.org/show_bug.cgi?id=54425
Attachment 82400: 54425
https://bugs.webkit.org/attachment.cgi?id=82400&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82400&action=review
Seems OK. Not sure it needs to be a member function. I don’t see uses of data
or function members. If I am right it could be a static member function or
event a non-member function. Non-member would be good because we wouldn’t have
to touch the header file.
> Source/WebCore/dom/Range.cpp:866
> + return clonedContainer;
Should be clonedContainer.release().
More information about the webkit-reviews
mailing list