[webkit-reviews] review requested: [Bug 48510] [GTK] Implement WebEventFactory, WebErrors classes for WebKit2 : [Attachment 82468] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 15 09:04:39 PST 2011


Alejandro G. Castro <alex at igalia.com> has asked  for review:
Bug 48510: [GTK] Implement WebEventFactory, WebErrors classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510

Attachment 82468: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=82468&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
Thanks for the reviews, I've added all the comments and other issues I've
spotted. Regarding the click count we had the same code to generate the events
in webkit1. Basically this should be used inside the widget event handler to
generate the webkit platform event that we are going to pass to webcore, so in
theory we could add the code we have in the widget in the same place for
webkit2. I guess this starts to be a proper first version but still things to
check and finish.


More information about the webkit-reviews mailing list