[webkit-reviews] review granted: [Bug 51339] [Qt] Redesign the build system : [Attachment 82452] patch part1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 15 08:07:21 PST 2011


Csaba Osztrogonac <ossy at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 51339: [Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Attachment 82452: patch part1
https://bugs.webkit.org/attachment.cgi?id=82452&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82452&action=review

Good cleanup! r=me. 
Please do a clean build on the buildbots if it is necessary.

> Source/WebCore/CodeGenerators.pri:655
> +inspectorBackendStub.wkAddOutputToSources = false

Please add a comment to ChangeLog about this change before landing.

> Source/WebCore/CodeGenerators.pri:662
> +injectedScriptSource.wkAddOutputToSources = false

ditto

> Source/WebCore/CodeGenerators.pri:671
> +tokenizer.wkAddOutputToSources = false

ditto


More information about the webkit-reviews mailing list