[webkit-reviews] review granted: [Bug 54437] Web Inspector: move rest of the tests off old harness. : [Attachment 82422] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 15 01:38:19 PST 2011
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 54437: Web Inspector: move rest of the tests off old harness.
https://bugs.webkit.org/show_bug.cgi?id=54437
Attachment 82422: Patch
https://bugs.webkit.org/attachment.cgi?id=82422&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82422&action=review
>
LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.ht
ml:13
> +window.addEventListener("message", receiveMessage, false);
What's the reason for moving this line?
> LayoutTests/http/tests/inspector/resources/extension-main.html:5
> +function dumpObject(object, nondeterministicProps, prefix, firstLinePrefix)
Why not use InspectorTest.addObject instead of this custom function?
More information about the webkit-reviews
mailing list