[webkit-reviews] review requested: [Bug 54439] [EFL] New API for executing Editor Commands: InsertText, InsertImage. : [Attachment 82425] patch

[bugzilla-daemon at webkit.org]

Kamil Blank <k.blank at samsung.com> has asked  for review:
Bug 54439: [EFL] New API for executing Editor Commands: InsertText,
InsertImage.
https://bugs.webkit.org/show_bug.cgi?id=54439

Attachment 82425: patch
https://bugs.webkit.org/attachment.cgi?id=82425&action=review

------- Additional Comments from Kamil Blank <k.blank at samsung.com>
I'd like to add new functionalities to be executed by EditorCommand -
InsertText, InsertImage.
I decided to do it in a different way than previous commands: "SelectWord",
"SelectLine" etc. 
I believe that having one function for all commands is much better than tens of
similar functions 
(what is possible as EditorCommand has a lot of commands defined).

Due to this fact I was also thinking about replacing existing functions (listed
below) by additional enums in Ewk_Editor_Command
but I'm not sure whether removing API is a good idea, what do you think?

List of existing editor commands:
EAPI Eina_Bool	  ewk_view_select_none(Evas_Object *o);
EAPI Eina_Bool	  ewk_view_select_all(Evas_Object *o);
EAPI Eina_Bool	  ewk_view_select_paragraph(Evas_Object *o);
EAPI Eina_Bool	  ewk_view_select_sentence(Evas_Object *o);
EAPI Eina_Bool	  ewk_view_select_line(Evas_Object *o);
EAPI Eina_Bool	  ewk_view_select_word(Evas_Object *o);