[webkit-reviews] review granted: [Bug 53213] Refactoring: Extract TextCheckerClient from EditorClient : [Attachment 82409] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 53213: Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

Attachment 82409: Patch
https://bugs.webkit.org/attachment.cgi?id=82409&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82409&action=review

r=me provided you fix copyright statement & a really long comment as described
below.

> Source/WebCore/editing/SpellChecker.cpp:46
> -SpellChecker::SpellChecker(Frame* frame, EditorClient* client)
> +SpellChecker::SpellChecker(Frame* frame, TextCheckerClient* client)

Ah, beautiful! Only one line changed in this file.

> Source/WebCore/platform/text/TextCheckerClient.h:18
> + *	  * Neither the name of Google Inc. nor the names of its
> + * contributors may be used to endorse or promote products derived from
> + * this software without specific prior written permission.

Mn... you grabbed a wrong version here.  Take a look at EditingStyle.cpp.

> Source/WebCore/platform/text/TextCheckerClient.h:82
> +    // For spellcheckers that support multiple languages, it's often
important to be able to identify the language in order to provide more accurate
correction suggestions. Caller can pass in more text in "context" to aid such
spellcheckers on language identification. Noramlly it's the text surrounding
the "word" for which we are getting correction suggestions.

You should split this long sentence into several lines.  On IDEs that permit
1000+ columns per line, this line will be hard to read.