[webkit-reviews] review granted: [Bug 54381] Sketch script-src for Content Security Policy : [Attachment 82403] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 14 18:54:23 PST 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 54381: Sketch script-src for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54381

Attachment 82403: Patch
https://bugs.webkit.org/attachment.cgi?id=82403&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82403&action=review

> Source/WebCore/page/ContentSecurityPolicy.cpp:87
> +	   parseDirective(pos, end, name, value);
> +	   if (name.isEmpty())
> +	       continue;

I would have probably had this return true/false for success.  But this is good
too.


More information about the webkit-reviews mailing list