[webkit-reviews] review denied: [Bug 52417] Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard : [Attachment 81592] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 52417: Add EditorClient callbacks to override isDOMPasteAllowed and
javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Attachment 81592: Patch
https://bugs.webkit.org/attachment.cgi?id=81592&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81592&action=review

> Source/WebCore/editing/EditorCommand.cpp:1129
> +    EditorClient* client = frame->editor()->client();
> +    if (client && client->canCopyCut())
> +	   return true;

It's strange that if the client returns false from canCopyCut, the web page
might still be able to copy or cut.  That's why I recommended the design we use
for allowPlugins where we pass the default as a parameter.  That way its easy
for the client to accept the default and also easy for the client to have the
final say.