[webkit-reviews] review granted: [Bug 54219] Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy : [Attachment 82399] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 14 18:08:16 PST 2011


Mihai Parparita <mihaip at chromium.org> has granted Charles Reis
<creis at chromium.org>'s request for review:
Bug 54219: Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=54219

Attachment 82399: Patch
https://bugs.webkit.org/attachment.cgi?id=82399&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
This minimally-invasive change seems fine to not hold up the release, but I'd
like a more through follow-up fix too (e.g. change chromium's WebFrameImpl to
use Page::goToItem and/or stop loaders, and add an assert in
HistoryController::goToItem that checks that loading is stopped).


More information about the webkit-reviews mailing list