[webkit-reviews] review denied: [Bug 54381] Sketch script-src for Content Security Policy : [Attachment 82395] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 54381: Sketch script-src for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54381

Attachment 82395: Patch
https://bugs.webkit.org/attachment.cgi?id=82395&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82395&action=review

> Source/WebCore/page/ContentSecurityPolicy.cpp:130
> +	   emitDirective(String(name), String(value));
> +	   name.clear();
> +	   value.clear();

This still feels strange.  Seems you should have an emitAndClear function to
wrap this copy/paste.

> Source/WebCore/page/ContentSecurityPolicy.h:49
>      bool m_isEnabled;

This name doesn't make much sense.  Seems you could have parsed already and not
have "enabled".