[webkit-reviews] review denied: [Bug 54287] SubresourceLoader should expose finish time : [Attachment 82397] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 54287: SubresourceLoader should expose finish time
https://bugs.webkit.org/show_bug.cgi?id=54287

Attachment 82397: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=82397&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82397&action=review

Just some minor nits to address and then this one will be done.

> Source/WebCore/loader/DocumentThreadableLoader.cpp:234
> +void DocumentThreadableLoader::didFinishLoading(SubresourceLoader* loader,
double finishTime)

I would leave out the parameter name "finishTime". Since it isn't used in this
function, I believe it will cause a compile error (with some builds like the
WebKit build on OSX) if you include it.

> Source/WebCore/loader/SubresourceLoaderClient.h:51
> +    virtual void didFinishLoading(SubresourceLoader*, double) { }

It would be good to include the name here /*finishTime*/ like other places so
that one can look at this header and tell what this parameter is about.

> Source/WebCore/loader/cache/CachedResourceRequest.cpp:140
> +void CachedResourceRequest::didFinishLoading(SubresourceLoader* loader,
double finishTime)

I would leave out the parameter name "finishTime" here. Same reasoning as
before.

> Source/WebCore/loader/icon/IconLoader.cpp:134
> +void IconLoader::didFinishLoading(SubresourceLoader* resourceLoader, double
finishTime)

I would leave out the parameter name "finishTime" here. Same reasoning as
before.