[webkit-reviews] review denied: [Bug 54292] remove the support of Frame::isContentEditable and Editor::clientIsEditable : [Attachment 82337] fix patch 3

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Chang Shu <cshu at webkit.org>'s
request for review:
Bug 54292: remove the support of Frame::isContentEditable and
Editor::clientIsEditable
https://bugs.webkit.org/show_bug.cgi?id=54292

Attachment 82337: fix patch 3
https://bugs.webkit.org/attachment.cgi?id=82337&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82337&action=review

r- because this patch will break WebKit API in many ports.

> Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:-486
> -    return webkit_web_view_get_editable(m_webView);

It seems like we're regressing GTK port this way.  We need to modify
webkit_web_view_set_editable/webkit_web_view_get_editable so that it properly
turns on/off design-mode.

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:-251
> -    return [m_webView isEditable];

Ditto.	We need to update setEditable in WebKit/mac/WebView/WebView.mm to turn
on/off design mode for mac port as well.

> Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp:-243
> -    return m_page->isContentEditable();

We need to update QWebPage::setContentEditable as well.

> Source/WebKit/wx/WebKitSupport/EditorClientWx.cpp:-207
> -	   if (webKitWin) 
> -	       return webKitWin->IsEditable();

We also need to modify Wx port as well but they're doing something funky like
executing any editing command only if the frame is editable.  We need someone
who knows Wx port here.