[webkit-reviews] review denied: [Bug 27798] [chromium] Media control panel for <video> in MediaDocument is mis-placed : [Attachment 82363] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 27798: [chromium] Media control panel for <video> in MediaDocument is
mis-placed
https://bugs.webkit.org/show_bug.cgi?id=27798

Attachment 82363: Patch
https://bugs.webkit.org/attachment.cgi?id=82363&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82363&action=review

A new bug is preferred for new work/patches -- otherwise it can be confusing to
sort through the comments (which pertain to the current patch and which pertain
to the old patch).

> Source/WebCore/ChangeLog:13
> +	   No new tests. (OOPS!)

This line needs to be replaced :)

A few choices:
1. Indicate what test you're adding.
2. Indicate what test covers the functionality.
3. Indicate why a test isn't necessary (No new functionality, so no new tests.)
(Hint that isn't the case here because you're changing something that is
visible.)
4. Indicate why a test isn't possible (You should add functionality to
dumprendertree if necessary to test, so this is almost never the correct
answer.)