[webkit-reviews] review granted: [Bug 54074] nrwt multiprocessing: add in per-worker, per-shard stats : [Attachment 82219] merge in changes from 54070, 54071, 54072, update w/ ojan's feedback

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 54074: nrwt multiprocessing: add in per-worker, per-shard stats
https://bugs.webkit.org/show_bug.cgi?id=54074

Attachment 82219: merge in changes from 54070, 54071, 54072, update w/ ojan's
feedback
https://bugs.webkit.org/attachment.cgi?id=82219&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82219&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:62
> +	   self.stats = {}
> +	   self.stats['name'] = worker_connection.name
> +	   self.stats['num_tests'] = 0
> +	   self.stats['total_time'] = 0

Nit: I would declare this inline, but I don't feel strongly about it.  Someday
we should convert this to a class.
self.stats = {
    'name': worker_connection.name,
    'num_tests': 0,
    'total_time': 0,
}

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:211
> +	   self._group_stats[list_name] = (num_tests, elapsed_time)
>	   pass

Remove 'pass'