[webkit-reviews] review granted: [Bug 54408] Fix Mutex::tryLock() on Windows to work properly with PlatformCondition::timedWait() : [Attachment 82352] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 14 12:59:45 PST 2011


Alexey Proskuryakov <ap at webkit.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 54408: Fix Mutex::tryLock() on Windows to work properly with
PlatformCondition::timedWait()
https://bugs.webkit.org/show_bug.cgi?id=54408

Attachment 82352: Patch
https://bugs.webkit.org/attachment.cgi?id=82352&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Seems fine to make this change, although the design seems surprising. Why is
the boolean variable shared between threads needed at all? Can you just use
wait/signal without a separate boolean variable?


More information about the webkit-reviews mailing list