[webkit-reviews] review granted: [Bug 54072] nrwt multiprocessing: add code to handle interrupts and wedged threads : [Attachment 82218] merge in more changes from 54070, 54071

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 54072: nrwt multiprocessing: add code to handle interrupts and wedged
threads
https://bugs.webkit.org/show_bug.cgi?id=54072

Attachment 82218: merge in more changes from 54070, 54071
https://bugs.webkit.org/attachment.cgi?id=82218&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82218&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:279

> +    def is_alive(self):
> +	   # FIXME: We can remove this once everyone is on 2.6.
> +	   return self.isAlive()

is_alive = isAlive (probably with the comment).

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:328

> +	       _Multiprocessing_Process.is_alive(self)

multiprocessing.Process.is_alive

My earlier thought was if _Process/_MultiProcessWorkerConnection is the same as
_Thread/_ThreadedWorkerConnection on python 2.5, maybe we shouldn't even
declare this object in python 2.5 (i.e., put the whole class definition behind
an if multiprocessing).  That would avoid some of these branches in the object
itself.

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unitte
st.py:192
> +	   oc.restore_output()

Should this be part of the try/finally?

> Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py:87
> +		   # FIXME: Figure out how to send a message with a traceback.

I see, the traceback can't be pickled?	Maybe we should just send back the
stringified traceback?