[webkit-reviews] review denied: [Bug 49750] [Qt] Compile with QT_NO_GRAPHICSVIEW : [Attachment 81391] rebaseline + minor fixes as suggested

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at nokia.com> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 49750: [Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750

Attachment 81391: rebaseline + minor fixes as suggested
https://bugs.webkit.org/attachment.cgi?id=81391&action=review

------- Additional Comments from Alexis Menard <alexis.menard at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81391&action=review

> Source/WebKit/qt/Api/qwebview.cpp:38
> +

Why this include?

> Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:-20
> -#include "../util.h"

Could you instead edit the tests.pro and remove the subdir completely? If the
config is minimal then don't add the dir, It's a bit more elegant to me.

> Tools/QtTestBrowser/launcherwindow.h:98
> +#endif

It needs a rebase the code changed a bit. No big deal though.