[webkit-reviews] review denied: [Bug 54385] Web Inspector: [Chromium] Landing detailed heap snapshots, part 3 : [Attachment 82301] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 54385: Web Inspector: [Chromium] Landing detailed heap snapshots, part 3
https://bugs.webkit.org/show_bug.cgi?id=54385

Attachment 82301: patch
https://bugs.webkit.org/attachment.cgi?id=82301&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82301&action=review

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:34
> +    this.defaultPopulateCount = populateCount;

_defaultPopulateCount

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:35
> +    this.provider = null;

this._provider

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:53
> +	       this.provider.sort(this.comparator());

{ on the next line.

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:325
> +    this.isDeletedNode = !!baseSnapshot;

Should be private

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:399
> +    this.name = constructor;

Make thing private.

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:476
> +    this.it1 = it1;

Make things private please.