[webkit-reviews] review denied: [Bug 54000] [Qt] Crash on application exit after constructing and destroying a QWebView twice : [Attachment 82310] Patch with test case

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Alexis Menard
<alexis.menard at nokia.com>'s request for review:
Bug 54000: [Qt] Crash on application exit after constructing and destroying a
QWebView twice
https://bugs.webkit.org/show_bug.cgi?id=54000

Attachment 82310: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=82310&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82310&action=review

> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2823
> +    for (int i = 0; i < 2; ++i)

Coding style, { on this line.

> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2831
> +	   webView->load(QUrl(QLatin1String("http://www.google.com/")));
> +	   mainWindow.show();
> +	   connect(webView, SIGNAL(loadFinished(bool)), &mainWindow,
SLOT(close()));
> +	   QApplication::instance()->exec();

We can't rely on external websites in our autotests.