[webkit-reviews] review granted: [Bug 54379] Add basic parser for Content Security Policy : [Attachment 82296] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 54379: Add basic parser for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54379

Attachment 82296: Patch
https://bugs.webkit.org/attachment.cgi?id=82296&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82296&action=review

LGTM. I look forward to seeing this testable in the next patch. :)

> Source/WebCore/page/ContentSecurityPolicy.cpp:117
> +	       m_directives.append(CSPDirective(String(name), String(value)));

You should explain why you use this method for creating strings, since you say
it does only 2 mallocs instead of 4.  Seems like a useful comment.