[webkit-reviews] review denied: [Bug 54375] [Chromium] REGRESSION(r77370): Wrong right offset for RTL popup : [Attachment 82288] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 54375: [Chromium] REGRESSION(r77370): Wrong right offset for RTL popup
https://bugs.webkit.org/show_bug.cgi?id=54375

Attachment 82288: Patch
https://bugs.webkit.org/attachment.cgi?id=82288&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82288&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

Please remove this line.

> Source/WebCore/ChangeLog:15
> +	   (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Change the
input parameter to take |popupInitialCoordinate| again. And calculate correct
right position with returned right offset from layoutAndRightOffset().

We don't use the || notation in WebKit.  Please remove it.

> Source/WebCore/ChangeLog:17
> +	   (WebCore::PopupContainer::layoutAndRightOffset): Change the name
from layout() and to return |rightOffset| value.

ditto.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:351
> +	   // Use |popupInitialCoordinate.x()| + |rightOffset| because RTL
position

ditto.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:415
> +int PopupContainer::layoutAndRightOffset()

The name layoutAndRightOffset() looks curious.	Maybe layoutAndGetRightOffset()
is better?