[webkit-reviews] review denied: [Bug 54374] Add method to make BuildBot return test outputs : [Attachment 82285] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 13 23:16:27 PST 2011


Ojan Vafai <ojan at chromium.org> has denied James Kozianski <koz at chromium.org>'s
request for review:
Bug 54374: Add method to make BuildBot return test outputs
https://bugs.webkit.org/show_bug.cgi?id=54374

Attachment 82285: Patch
https://bugs.webkit.org/attachment.cgi?id=82285&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82285&action=review

r- for lack of unittests.

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:97
> +    def latest_build(self):

Nit: while I can see why this might be a useful method, it's not actually used
in this patch or described in the ChangeLog description. A one-liner in the
ChangeLog description of what this is to be used for would be good.


More information about the webkit-reviews mailing list