[webkit-reviews] review denied: [Bug 54333] Expose checked field of HTMLInputElement to Chromium API : [Attachment 82226] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 13 21:02:33 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jay Soffian
<jaysoffian at gmail.com>'s request for review:
Bug 54333: Expose checked field of HTMLInputElement to Chromium API
https://bugs.webkit.org/show_bug.cgi?id=54333

Attachment 82226: Patch
https://bugs.webkit.org/attachment.cgi?id=82226&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82226&action=review

> w/Source/WebKit/chromium/public/WebInputElement.h:81
> +	   WEBKIT_API bool checked() const;

How about renaming this to isChecked to be more consistent with how other,
similar API methods are named?
"checked" is really trying to ask a question, so it helps to word it like a
question.


More information about the webkit-reviews mailing list