[webkit-reviews] review denied: [Bug 54365] GraphicsContext: Add clip(IntRect) overload for Qt : [Attachment 82278] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 54365: GraphicsContext: Add clip(IntRect) overload for Qt
https://bugs.webkit.org/show_bug.cgi?id=54365

Attachment 82278: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=82278&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82278&action=review

> Source/WebCore/platform/graphics/GraphicsContext.h:326
> +#if PLATFORM(QT)
> +	   void clip(const IntRect&);
> +#endif

I think we should add this cross-platform. For the other platforms we can the
graphics context code convert the rectangle to floating point. You could put
the version for all other platforms into GraphicsContextQt.cpp inside an #if
!PLATFORM(QT) block.

We really don’t want to start putting PLATFORM(QT) if statements into call
sites!