[webkit-reviews] review denied: [Bug 54352] [GTK] Match more various WebKit API enum values with WebCore enum values : [Attachment 82259] Proposed Patch2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 13 09:07:58 PST 2011


Martin Robinson <mrobinson at webkit.org> has denied Joone Hur <joone at kldp.org>'s
request for review:
Bug 54352: [GTK] Match more various WebKit API enum values with WebCore enum
values
https://bugs.webkit.org/show_bug.cgi?id=54352

Attachment 82259: Proposed Patch2
https://bugs.webkit.org/attachment.cgi?id=82259&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82259&action=review

This is awesome, though we cannot break the ABI. Without the last change it's
fine though.

> Source/WebKit/gtk/webkit/webkitwebview.h:64
> +    WEBKIT_WEB_VIEW_VIEW_MODE_INVALID,

I think this might be an ABI break. :(


More information about the webkit-reviews mailing list