[webkit-reviews] review granted: [Bug 54348] Crash when printing a document with no pages : [Attachment 82249] proposed fix

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 54348: Crash when printing a document with no pages
https://bugs.webkit.org/show_bug.cgi?id=54348

Attachment 82249: proposed fix
https://bugs.webkit.org/attachment.cgi?id=82249&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=82249&action=review

> Source/WebKit2/ChangeLog:8
> +	   * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawPagesToPDF):
Don't fail on a fake

Can you add a newline between the filename and the function name?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2015
> +	   CGRect mediaBox = m_printContext->pageCount() ?
m_printContext->pageRect(0) : CGRectMake(0, 0, 1, 1);

What happens if you use CGRectZero instead?