[webkit-reviews] review denied: [Bug 54108] Layout stall waiting for external scripts to load : [Attachment 82234] Makes initial layout/paint appear sooner by prioritizing scripts by domain-origin (compiled and tested working)

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has denied  review:
Bug 54108: Layout stall waiting for external scripts to load
https://bugs.webkit.org/show_bug.cgi?id=54108

Attachment 82234: Makes initial layout/paint appear sooner by prioritizing
scripts by domain-origin (compiled and tested working)
https://bugs.webkit.org/attachment.cgi?id=82234&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82234&action=review

> Source/WebCore/html/parser/HTMLScriptRunner.cpp:316
> +		       requestDeferredScript(script);

Yes, deferred scripts can be much faster than parsing blocking ones, so I'm not
surprised you are seeing big performance wins here. But It isn't correct to
treat a parsing blocking script as a deferred script. This would be a violation
of the HTML5 spec and lead to broken sites because the execution order changes.
The correct approach here is not a webkit change, but rather to evangelize that
web sites use deferred or async scripts if the order they execute is not
important.