[webkit-reviews] review granted: [Bug 54321] [chromium] Allow turning off multisampling through web reference settings : [Attachment 82203] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 54321: [chromium] Allow turning off multisampling through web reference
settings
https://bugs.webkit.org/show_bug.cgi?id=54321

Attachment 82203: Patch
https://bugs.webkit.org/attachment.cgi?id=82203&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82203&action=review

Basically looks fine with a couple of nits. Appreciate your fixing upon commit.


> Source/WebCore/ChangeLog:5
> +	   [chromium] Allow turning off multisampling through web reference
settings

reference -> preference

> Source/WebCore/ChangeLog:10
> +	   * page/Settings.cpp: Add a fflag for multisampling preference.

typo: fflag

> Source/WebCore/ChangeLog:14
> +	   (WebCore::Settings::setGLMultisamplingEnabled):
> +	   * page/Settings.h: Ditto.
> +	   (WebCore::Settings::GLMultisamplingEnabled):

These don't match WebKit capitalization conventions. I'd suggest
"setOpenGLMultisamplingEnabled" / "openGLMultisamplingEnabled".

> Source/WebKit/chromium/ChangeLog:5
> +	   [chromium] Allow turning off multisampling through web reference
settings

again, reference -> preference