[webkit-reviews] review denied: [Bug 54315] [chromium] Update texture for ContentLayerChromiums in draw() call instead of updateContents..() call : [Attachment 82188] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 54315: [chromium] Update texture for ContentLayerChromiums in draw() call
instead of updateContents..() call
https://bugs.webkit.org/show_bug.cgi?id=54315

Attachment 82188: Patch
https://bugs.webkit.org/attachment.cgi?id=82188&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82188&action=review

> Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:299
> +	   SkAutoLockPixels lock(bitmap);
> +	   // FIXME: do we need to support more image configurations?
> +	   if (bitmap.config() == SkBitmap::kARGB_8888_Config)
> +	       pixels = bitmap.getPixels();

This looks unsafe. The SkAutoLockPixels goes out of scope here but pixels is
used later.