[webkit-reviews] review denied: [Bug 54287] SubresourceLoader should expose finish time : [Attachment 82171] Proposed patch with testing field filled in.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 14:12:40 PST 2011


David Levin <levin at chromium.org> has denied  review:
Bug 54287: SubresourceLoader should expose finish time
https://bugs.webkit.org/show_bug.cgi?id=54287

Attachment 82171: Proposed patch with testing field filled in.
https://bugs.webkit.org/attachment.cgi?id=82171&action=review

------- Additional Comments from David Levin <levin at chromium.org>
ok, this doesn't apply but I got to thinking about it more.  I looked at the
original bug and then started wondering why we are pushing this down into
subresource loader when only one user needs it.

After all, it seems that instead of having purely a "DummyClient", you could
fill in the "didFinishLoading" method and make it capture the finishTime. Then
we don't add more code into subresource loader (which only one user of it cares
about).


More information about the webkit-reviews mailing list