[webkit-reviews] review denied: [Bug 54079] nrwt multiprocessing: move non-testing logic out of single_test_runner, create worker_mixin : [Attachment 81771] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has denied Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 54079: nrwt multiprocessing: move non-testing logic out of
single_test_runner, create worker_mixin
https://bugs.webkit.org/show_bug.cgi?id=54079

Attachment 81771: Patch
https://bugs.webkit.org/attachment.cgi?id=81771&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81771&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:31
> +import os

Not seeing any usage of is in this file.

> Tools/Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:50
> +    def deferred_init(self, port):

The naming of this confused me; what is supposed to be deferred about it?

> Tools/Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:57
> +	   self._has_http_lock = False

Seems strange that you have to maintain your own flag instead of having it in
the port, which actually acquires the lock. Should this be moved there?