[webkit-reviews] review denied: [Bug 54193] Implement IDBObjectStore::clear : [Attachment 82135] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied jochen at chromium.org's request for
review:
Bug 54193: Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193

Attachment 82135: Patch
https://bugs.webkit.org/attachment.cgi?id=82135&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82135&action=review

close

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:390
> +	   return;

not needed...so you can get rid of the {}'s too

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:405
> +    doClear(objectStore->sqliteDatabase(), "DELETE FROM ObjectStoreData");

Sorry for missing this earlier, but you need to only delete the data for your
object store.  Please make sure your layout test double checks this as well.