[webkit-reviews] review denied: [Bug 54089] Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view : [Attachment 82126] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 06:32:13 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at google.com>'s request for review:
Bug 54089: Web Inspector: [REGRESSION] click on error message in console
doesn't scroll into view
https://bugs.webkit.org/show_bug.cgi?id=54089

Attachment 82126: Patch
https://bugs.webkit.org/attachment.cgi?id=82126&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82126&action=review

> Source/WebCore/ChangeLog:5
> +	   Web Inspector: [REGRESSION] click on error message in console
doesn't scroll into view

It is not clear why this regressed. Could you please put more info into the
change log?

> Source/WebCore/inspector/front-end/Drawer.js:183
> +	       this.mainStatusBar.insertBefore(anchoredItems,
this.mainStatusBar.firstChild);

These should be private (this._main ...)


More information about the webkit-reviews mailing list