[webkit-reviews] review granted: [Bug 54195] Web Inspector: refactoring, extract SourceMapping from SourceFrameContent : [Attachment 81957] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 54195: Web Inspector: refactoring, extract SourceMapping from
SourceFrameContent
https://bugs.webkit.org/show_bug.cgi?id=54195

Attachment 81957: Patch.
https://bugs.webkit.org/attachment.cgi?id=81957&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81957&action=review

> Source/WebCore/inspector/front-end/ScriptFormatter.js:200
> +    fromScriptLocation: function(lineNumber, columnNumber)

The method name is confusing, should be something like
originalToFormattedLocation

> Source/WebCore/inspector/front-end/ScriptFormatter.js:206
> +    toScriptLocation: function(lineNumber, columnNumber)

Ditto.