[webkit-reviews] review requested: [Bug 53749] Templatize KURLGooglePrivate::init : [Attachment 82099] Reworked patch

[bugzilla-daemon at webkit.org]

Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 53749: Templatize KURLGooglePrivate::init
https://bugs.webkit.org/show_bug.cgi?id=53749

Attachment 82099: Reworked patch
https://bugs.webkit.org/attachment.cgi?id=82099&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
(In reply to comment #13)
> We usually put the body of the templated function in the header, but if this
works, its fine.  We can always move the function later if we need to.

Thank you for the r+, Adam, but now I'm thinking:
Would it not be better to clearly indicate that the template is only a helper,
not to be called from the outside (hence no template body in the header), and
name it the same way in which googleurl internal helpers are named?

I renamed the template helper to doInit, and I added a comment in
KURLGooglePrivate.h about its internal-only use. Should it ever need to be used
from outside, then it can be renamed back to init, and moved to the header.

I also fixed another bunch of comment typos along the way.