[webkit-reviews] review granted: [Bug 54270] A little more encapsulation for MarkedBlock: Made all constants private so clients don't know whether allocations are fixed-sized or not : [Attachment 82098] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 21:21:07 PST 2011


Sam Weinig <sam at webkit.org> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 54270: A little more encapsulation for MarkedBlock: Made all constants
private so clients don't know whether allocations are fixed-sized or not
https://bugs.webkit.org/show_bug.cgi?id=54270

Attachment 82098: Patch
https://bugs.webkit.org/attachment.cgi?id=82098&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82098&action=review

> Source/JavaScriptCore/runtime/JSGlobalData.cpp:90
> +    char storage[64];

I think this wonky size could use a comment.


More information about the webkit-reviews mailing list