[webkit-reviews] review denied: [Bug 54258] Make class Mutex work for Pthreads implementation with recursive mutexes : [Attachment 82077] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 54258: Make class Mutex work for Pthreads implementation with recursive
mutexes
https://bugs.webkit.org/show_bug.cgi?id=54258

Attachment 82077: Patch
https://bugs.webkit.org/attachment.cgi?id=82077&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that this has race conditions in updating m_recursionCount. In
unlock(), you decrease the count after unlocking, but another thread can
already take this mutex, and be increasing the count.

pthread_cond_wait() temporarily releases the mutex - should the count be
decreased, too?

Following tryLock() was just too difficult for me.

Can you name the platform this is needed for? Can a proper mutex be added to
its pthreads implementation instead?