[webkit-reviews] review denied: [Bug 53390] Files missing ENABLE_VIDEO #ifdef : [Attachment 81738] wrap HTMLVideoElement references with ENABLE(VIDEO) ifdef in WebGLRenderingContext

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 17:55:39 PST 2011


David Levin <levin at chromium.org> has denied Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 53390: Files missing ENABLE_VIDEO #ifdef
https://bugs.webkit.org/show_bug.cgi?id=53390

Attachment 81738: wrap HTMLVideoElement references with ENABLE(VIDEO) ifdef in
WebGLRenderingContext
https://bugs.webkit.org/attachment.cgi?id=81738&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81738&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2988
>  PassRefPtr<Image> WebGLRenderingContext::videoFrameToImage(HTMLVideoElement*
video)

Can't you put the #if ENABLE(VIDEO) on the outside of this method? (In the
header too.)

Ditto for the other instances in this file.


More information about the webkit-reviews mailing list