[webkit-reviews] review granted: [Bug 54257] Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass : [Attachment 82071] [PATCH] Proposed Solution

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 54257: Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass
https://bugs.webkit.org/show_bug.cgi?id=54257

Attachment 82071: [PATCH] Proposed Solution
https://bugs.webkit.org/attachment.cgi?id=82071&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82071&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   A subclass may want to specify the CFRunLoop the Garbage Collection.
It

Typo, I think.

> Source/JavaScriptCore/runtime/GCActivityCallbackCF.cpp:86
> +    memset(&d->context, '\0', sizeof(CFRunLoopTimerContext));

'\0' is a strange way to say '0'. I know you didn't write this code initially,
but you might as well change it to '0'.