[webkit-reviews] review granted: [Bug 54245] Cached JavaScript Parser Data Being Left in Memory Cache : [Attachment 82068] Updated Patch with Windows export of SourceProviderCache::clear()

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 54245: Cached JavaScript Parser Data Being Left in Memory Cache
https://bugs.webkit.org/show_bug.cgi?id=54245

Attachment 82068: Updated Patch with Windows export of
SourceProviderCache::clear()
https://bugs.webkit.org/attachment.cgi?id=82068&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82068&action=review

r=me

> Source/WebCore/ChangeLog:8
> +	   Added logic in CachedScript to clear SourceProviderCache data in

I think it's worth mentioning the improvement you measured on membuster, for
the benefit of future readers.

> Source/WebCore/loader/cache/CachedScript.cpp:129
> -    // FIXME: SourceInfoCache should be wiped out too but not this easily.
> +    if (m_sourceProviderCache)
> +	   m_sourceProviderCache->clear();

I thought this juxtaposition was cool :).