[webkit-reviews] review granted: [Bug 54224] toDataURL() fails if skia device is backed by GPU : [Attachment 82014] add explicit test that exercises this code path, explicitly lockPixels() before calling getPixels()

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Mike Reed <reed at google.com>'s
request for review:
Bug 54224: toDataURL() fails if skia device is backed by GPU
https://bugs.webkit.org/show_bug.cgi?id=54224

Attachment 82014: add explicit test that exercises this code path, explicitly
lockPixels() before calling getPixels()
https://bugs.webkit.org/attachment.cgi?id=82014&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82014&action=review

Great!	Thanks for adding the test reference, it'll be useful to have this
information if that test every breaks in the future.  Would you like me to c-q+
this as well?

> WebCore/platform/graphics/skia/ImageBufferSkia.cpp:354
> +    // if we can't see the pixels directly, call readPixels() to get a copy.

> +    // this could happen if the device is backed by a GPU.
> +    bitmap.lockPixels(); // balanced by our destructor, or explicitly if
getPixels() fails

nit: In WebKit, comments start with an uppercase letter and end with a period.