[webkit-reviews] review granted: [Bug 54158] Throw exception when AudioContext's createBuffer() fails to properly decode audio file data : [Attachment 81910] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 54158: Throw exception when AudioContext's createBuffer() fails to properly
decode audio file data
https://bugs.webkit.org/show_bug.cgi?id=54158

Attachment 81910: Patch
https://bugs.webkit.org/attachment.cgi?id=81910&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81910&action=review

Looks fine to me. One minor comment.

> Source/WebCore/bindings/js/JSAudioContextCustom.cpp:73
> +	   if (arrayBuffer) {

To make the JSC and V8 bindings identical you should ASSERT(arrayBuffer) here.