[webkit-reviews] review granted: [Bug 54144] IndexedDB event targets need to ensure their wrappers arent garbage collected : [Attachment 82018] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 54144: IndexedDB event targets need to ensure their wrappers arent garbage
collected
https://bugs.webkit.org/show_bug.cgi?id=54144

Attachment 82018: Patch
https://bugs.webkit.org/attachment.cgi?id=82018&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82018&action=review

Code LGTM

> Source/WebCore/storage/IDBDatabase.cpp:146
> +    //	 get a handle to us or any deritivive transaction/request
object and any

Nit: deritivive -> derivative?

> Source/WebCore/storage/IDBRequest.cpp:172
> +    // fire again (unless the transaction completes

Nit: += ').'

> Source/WebCore/storage/IDBRequest.h:100
> +    bool m_finished; // Is it possible that we'll fire any more events? If
not, we're finished.

Is there some significance to IDBRequest and IDBTransaction using m_finished
and IDBDatabase using m_stopped?  I assume there's a good reason that these
variables don't have the same name for a similar concept?