[webkit-reviews] review granted: [Bug 54068] nrwt multiprocessing: implement a full set of stubs for testrunner, worker : [Attachment 82029] update w/ more review feedback from tony - make start_worker() virtual

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 54068: nrwt multiprocessing: implement a full set of stubs for testrunner,
worker
https://bugs.webkit.org/show_bug.cgi?id=54068

Attachment 82029: update w/ more review feedback from tony - make
start_worker() virtual
https://bugs.webkit.org/attachment.cgi?id=82029&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82029&action=review

I think it's ok to pass around worker_class for testability, but a bit
unfortunate.  I wonder if it would be possible to have a function on some
object that can be overridden with a sub class during testing.

If there's only Worker and TestWorker, I'd suggest removing AbstractWorker and
just use duck typing for testing.  That seems to be what we do for other mocks.


>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:204

> +	   _WorkerConnection.__init__(self, broker, worker_class,
worker_number, port._options)

I would just add a public accessor for options() in base.py.