[webkit-reviews] review requested: [Bug 53766] [Qt] Compilation error on OpenBSD : [Attachment 82034] Alternative Patch (with positiv listing)

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 53766: [Qt] Compilation error on OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=53766

Attachment 82034: Alternative Patch (with positiv listing)
https://bugs.webkit.org/attachment.cgi?id=82034&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82021&action=review

>> Source/JavaScriptCore/wtf/Platform.h:729
>> +#if !COMPILER(MSVC) && !COMPILER(RVCT) && !OS(WINDOWS) && !OS(LINUX) &&
!OS(SOLARIS) && !OS(OPENBSD)
> 
> Shouldn't that be the other way around:
> #if OS(MAC) || OS(FREEBSD)
> ?

Maybe yes, maybe no. ;-)
I don't know if it's defined at AIX, HAIKU, NETBSD, QNX, but changing this to
positiv listing is clearly better.

It seams that at least HAIKU needs this change too, so it's ok to take the risk
of breaking the build on some "uncommon" platforms IMHO.