[webkit-reviews] review denied: [Bug 54221] Fix clang warning "WebCore::HTMLAreaElement::getRect' hides overloaded virtual function [-Woverloaded-virtual]" : [Attachment 82000] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Nico Weber <thakis at chromium.org>'s
request for review:
Bug 54221: Fix clang warning "WebCore::HTMLAreaElement::getRect' hides
overloaded virtual function [-Woverloaded-virtual]"
https://bugs.webkit.org/show_bug.cgi?id=54221

Attachment 82000: Patch
https://bugs.webkit.org/attachment.cgi?id=82000&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I think a rename is totally fine.

But I don’t think that adding a “for renderer” suffix is the best rename. For
one thing, having “get” in these names doesn’t match our usual naming scheme.
So the Node::getRect function also has a bad name for a WebKit function.

I think I’d name them computeRect and computePath.

Since the patch isn’t applying with the EWS I think we need a new version.
review- because of the EWS issue.